feat(web): allow unsecure ssl proxy on file-server

Fix usage of self-signed certificates while using a proxy in file-server executor. See #5118
nrwl · Jan 27, 2022 · 1955462 · 1955462
1 parent 0959194
commit 1955462
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/docs/generated/api-web/executors/file-server.md b/docs/generated/api-web/executors/file-server.md
@@ -53,6 +53,12 @@ Type: `string`
 
 URL to proxy unhandled requests to.
 
+### secure
+
+Type: `boolean`
+
+True if you want to verify the SSL Certs.
+
 ### ssl
 
 Default: `false`

diff --git a/nx-dev/nx-dev/public/documentation/generated/api-web/executors/file-server.md b/nx-dev/nx-dev/public/documentation/generated/api-web/executors/file-server.md
@@ -53,6 +53,12 @@ Type: `string`
 
 URL to proxy unhandled requests to.
 
+### secure
+
+Type: `boolean`
+
+True if you want to verify the SSL Certs.
+
 ### ssl
 
 Default: `false`

diff --git a/packages/web/src/executors/file-server/file-server.impl.ts b/packages/web/src/executors/file-server/file-server.impl.ts
@@ -26,6 +26,9 @@ function getHttpServerArgs(options: Schema) {
   if (options.proxyUrl) {
     args.push(`-P ${options.proxyUrl}`);
   }
+  if (typeof options.secure === 'boolean') {
+    args.push(`--proxy-options.secure ${options.secure}`);
+  }
   return args;
 }
 

diff --git a/packages/web/src/executors/file-server/schema.d.ts b/packages/web/src/executors/file-server/schema.d.ts
@@ -5,6 +5,7 @@ export interface Schema {
   sslKey?: string;
   sslCert?: string;
   proxyUrl?: string;
+  secure?: boolean;
   buildTarget: string;
   parallel: boolean;
   maxParallel?: number;

diff --git a/packages/web/src/executors/file-server/schema.json b/packages/web/src/executors/file-server/schema.json
@@ -48,6 +48,10 @@
     "proxyUrl": {
       "type": "string",
       "description": "URL to proxy unhandled requests to."
+    },
+    "secure": {
+      "type": "boolean",
+      "description": "True if you want to verify the SSL Certs."
     }
   },
   "additionalProperties": false,