fix(react): fix remote generation devServerPort (#18603)

nrwl · Aug 21, 2023 · 1a0962f · 1a0962f · vercel · Aug 21, 2023
1 parent 18ba93a
commit 1a0962f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/docs/generated/packages/react/generators/remote.json b/docs/generated/packages/react/generators/remote.json
@@ -152,7 +152,6 @@
       "devServerPort": {
         "type": "number",
         "description": "The port for the dev server of the remote app.",
-        "default": 4200,
         "x-priority": "important"
       },
       "ssr": {

diff --git a/e2e/react-core/src/react-module-federation.test.ts b/e2e/react-core/src/react-module-federation.test.ts
@@ -43,6 +43,11 @@ describe('React Module Federation', () => {
       combinedOutput: expect.stringContaining('Test Suites: 1 passed, 1 total'),
     });
 
+    expect(readPort(shell)).toEqual(4200);
+    expect(readPort(remote1)).toEqual(4201);
+    expect(readPort(remote2)).toEqual(4202);
+    expect(readPort(remote3)).toEqual(4203);
+
     updateFile(
       `apps/${shell}/webpack.config.js`,
       stripIndents`

diff --git a/packages/react/src/generators/remote/schema.json b/packages/react/src/generators/remote/schema.json
@@ -158,7 +158,6 @@
     "devServerPort": {
       "type": "number",
       "description": "The port for the dev server of the remote app.",
-      "default": 4200,
       "x-priority": "important"
     },
     "ssr": {