fix(linter): Normalize paths when in getSourceFilePath (#18601)

Co-authored-by: jgelin <jgelin@seligent.com>
nrwl · Aug 17, 2023 · 1f9b3c4 · 1f9b3c4 · vercel · Aug 17, 2023
1 parent 2034cdd
commit 1f9b3c4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/utils/runtime-lint-utils.spec.ts b/packages/eslint-plugin/src/utils/runtime-lint-utils.spec.ts
@@ -9,6 +9,7 @@ import {
   DepConstraint,
   findConstraintsFor,
   findTransitiveExternalDependencies,
+  getSourceFilePath,
   hasBannedDependencies,
   hasBannedImport,
   hasNoneOfTheseTags,
@@ -558,3 +559,19 @@ describe('hasNoneOfTheseTags', () => {
     }
   );
 });
+
+describe('getSourceFilePath', () => {
+  it.each([
+    ['/root/libs/dev-kit/package.json', '/root'],
+    ['/root/libs/dev-kit/package.json', 'C:\\root'],
+    ['C:\\root\\libs\\dev-kit\\package.json', '/root'],
+    ['C:\\root\\libs\\dev-kit\\package.json', 'C:\\root'],
+  ])(
+    'should return "libs/dev-kit/package.json" when sourceFileName is "%s" and projectPath is "%s"',
+    (sourceFileName, projectPath) => {
+      expect(getSourceFilePath(sourceFileName, projectPath)).toBe(
+        'libs/dev-kit/package.json'
+      );
+    }
+  );
+});
diff --git a/packages/eslint-plugin/src/utils/runtime-lint-utils.ts b/packages/eslint-plugin/src/utils/runtime-lint-utils.ts
@@ -222,8 +222,9 @@ export function onlyLoadChildren(
 }
 
 export function getSourceFilePath(sourceFileName: string, projectPath: string) {
-  const relativePath = sourceFileName.slice(projectPath.length + 1);
-  return normalizePath(relativePath);
+  const normalizedProjectPath = normalizePath(projectPath);
+  const normalizedSourceFileName = normalizePath(sourceFileName);
+  return normalizedSourceFileName.slice(normalizedProjectPath.length + 1);
 }
 
 /**