fix(angular): handle packages with no exported package.json when coll…

…ecting secondary entry points for mf builds (#10216)
nrwl · May 9, 2022 · 2503592 · 2503592
1 parent e707461
commit 2503592
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 4 deletions.
diff --git a/packages/angular/src/utils/mfe/mfe-webpack.spec.ts b/packages/angular/src/utils/mfe/mfe-webpack.spec.ts
@@ -231,6 +231,25 @@ describe('MFE Webpack Utils', () => {
         },
       });
     });
+
+    it('should not throw when the main entry point package.json cannot be required', () => {
+      // ARRANGE
+      (fs.existsSync as jest.Mock).mockImplementation(
+        (file) => !file.endsWith('non-existent-top-level-package/package.json')
+      );
+      jest.spyOn(devkit, 'readJsonFile').mockImplementation((file) => ({
+        name: file
+          .replace(/\\/g, '/')
+          .replace(/^.*node_modules[/]/, '')
+          .replace('/package.json', ''),
+        dependencies: { '@angular/core': '~13.2.0' },
+      }));
+
+      // ACT & ASSERT
+      expect(() =>
+        sharePackages(['non-existent-top-level-package'])
+      ).not.toThrow();
+    });
   });
 });
 

diff --git a/packages/angular/src/utils/mfe/mfe-webpack.ts b/packages/angular/src/utils/mfe/mfe-webpack.ts
@@ -137,10 +137,23 @@ function collectPackageSecondaryEntryPoints(
   pkgVersion: string,
   collectedPackages: { name: string; version: string }[]
 ): void {
-  const packageJsonPath = require.resolve(`${pkgName}/package.json`, {
-    paths: [workspaceRoot],
-  });
-  const pathToPackage = dirname(packageJsonPath);
+  let pathToPackage: string;
+  try {
+    const packageJsonPath = require.resolve(`${pkgName}/package.json`, {
+      paths: [workspaceRoot],
+    });
+    pathToPackage = dirname(packageJsonPath);
+  } catch {
+    // the package.json might not resolve if the package has the "exports"
+    // entry and is not exporting the package.json file, fall back to trying
+    // to find it from the top-level node_modules
+    pathToPackage = join(workspaceRoot, 'node_modules', pkgName);
+    if (!existsSync(join(pathToPackage, 'package.json'))) {
+      // might not exist if it's nested in another package, just return here
+      return;
+    }
+  }
+
   const subDirs = getNonNodeModulesSubDirs(pathToPackage);
   recursivelyCollectSecondaryEntryPointsFromDirectory(
     pkgName,