Skip to content

Commit

Permalink
chore(js): rename loadTsPlugins function
Browse files Browse the repository at this point in the history
  • Loading branch information
Chau Tran authored and Chau Tran committed Mar 2, 2022
1 parent d1015b5 commit 30d4646
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
6 changes: 4 additions & 2 deletions packages/js/src/utils/typescript/compile-typescript-files.ts
Expand Up @@ -12,7 +12,7 @@ import type {
} from 'typescript';
import { createAsyncIterable } from '../create-async-iterable/create-async-iteratable';
import { NormalizedExecutorOptions } from '../schema';
import { loadTsPlugins } from './load-ts-plugins';
import { loadTsTransformers } from './load-ts-transformers';

export async function* compileTypeScriptFiles(
normalizedOptions: NormalizedExecutorOptions,
Expand All @@ -24,7 +24,9 @@ export async function* compileTypeScriptFiles(
outfile: normalizedOptions.mainOutputPath,
});

const { compilerPluginHooks } = loadTsPlugins(normalizedOptions.transformers);
const { compilerPluginHooks } = loadTsTransformers(
normalizedOptions.transformers
);

const getCustomTransformers = (program: Program): CustomTransformers => ({
before: compilerPluginHooks.beforeHooks.map(
Expand Down
@@ -1,22 +1,22 @@
import { loadTsPlugins } from './load-ts-plugins';
import { loadTsTransformers } from './load-ts-transformers';

jest.mock('plugin-a');
jest.mock('plugin-b');
const mockRequireResolve = jest.fn((path) => path);

describe('loadTsPlugins', () => {
describe('loadTsTransformers', () => {
it('should return empty hooks if plugins is falsy', () => {
const result = loadTsPlugins(undefined);
const result = loadTsTransformers(undefined);
assertEmptyResult(result);
});

it('should return empty hooks if plugins is []', () => {
const result = loadTsPlugins([]);
const result = loadTsTransformers([]);
assertEmptyResult(result);
});

it('should return correct compiler hooks', () => {
const result = loadTsPlugins(
const result = loadTsTransformers(
['plugin-a', 'plugin-b'],
mockRequireResolve as any
);
Expand All @@ -29,7 +29,7 @@ describe('loadTsPlugins', () => {
});
});

function assertEmptyResult(result: ReturnType<typeof loadTsPlugins>) {
function assertEmptyResult(result: ReturnType<typeof loadTsTransformers>) {
expect(result.hasPlugin).toEqual(false);
expect(result.compilerPluginHooks).toEqual({
beforeHooks: [],
Expand Down
Expand Up @@ -3,11 +3,11 @@ import { join } from 'path';
import {
CompilerPlugin,
CompilerPluginHooks,
TransformerPlugin,
TransformerEntry,
TransformerPlugin,
} from './types';

export function loadTsPlugins(
export function loadTsTransformers(
plugins: TransformerEntry[],
moduleResolver: typeof require.resolve = require.resolve
): {
Expand Down

0 comments on commit 30d4646

Please sign in to comment.