Skip to content

Commit

Permalink
chore(repo): remove obsolete NX_E2E_SKIP_DAEMON_CLEANUP flag (#9061)
Browse files Browse the repository at this point in the history
  • Loading branch information
meeroslav committed Feb 21, 2022
1 parent fc018cd commit 36245e1
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion .github/workflows/e2e-matrix.yml
Expand Up @@ -159,7 +159,6 @@ jobs:
YARN_REGISTRY: http://localhost:4872
NX_VERBOSE_LOGGING: ${{ 'true' }}
NX_E2E_SKIP_BUILD_CLEANUP: ${{ 'true' }}
NX_E2E_SKIP_DAEMON_CLEANUP: ${{ 'true' }}
NX_CACHE_DIRECTORY: ${{ matrix.os-cache-dir }}

- name: Setup tmate session
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/e2e-windows.yml
Expand Up @@ -77,7 +77,6 @@ jobs:
YARN_REGISTRY: http://localhost:4872
NX_VERBOSE_LOGGING: ${{ 'true' }}
NX_E2E_SKIP_BUILD_CLEANUP: ${{ 'true' }}
NX_E2E_SKIP_DAEMON_CLEANUP: ${{ 'true' }}
NX_CACHE_DIRECTORY: ./nx-cache

- name: Setup tmate session
Expand Down
4 changes: 0 additions & 4 deletions e2e/utils/index.ts
Expand Up @@ -302,10 +302,6 @@ export async function killPorts(port?: number): Promise<boolean> {
// Useful in order to cleanup space during CI to prevent `No space left on device` exceptions
export async function cleanupProject() {
if (isCI) {
// Stopping the daemon is not required for tests to pass, but it cleans up background processes
if (process.env.NX_E2E_SKIP_DAEMON_CLEANUP !== 'true') {
runCLI('reset');
}
try {
removeSync(tmpProjPath());
} catch (e) {}
Expand Down

0 comments on commit 36245e1

Please sign in to comment.