chore(repo): changes for review

nrwl · May 25, 2022 · 40b06e3 · 40b06e3
1 parent d156ff8
commit 40b06e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/packages/nx-plugin/src/generators/plugin/plugin.ts b/packages/nx-plugin/src/generators/plugin/plugin.ts
@@ -127,7 +127,6 @@ function updateWorkspaceJson(host: Tree, options: NormalizedSchema) {
 
 export async function pluginGenerator(host: Tree, schema: Schema) {
   const options = normalizeOptions(host, schema);
-  const tasks: GeneratorCallback[] = [];
 
   const libraryTask = await libraryGenerator(host, {
     ...schema,
@@ -136,8 +135,6 @@ export async function pluginGenerator(host: Tree, schema: Schema) {
     importPath: options.npmPackageName,
   });
 
-  tasks.push(libraryTask);
-
   addDependenciesToPackageJson(
     host,
     {},

diff --git a/packages/nx/src/utils/register.ts b/packages/nx/src/utils/register.ts
@@ -15,13 +15,11 @@ export const registerTsProject = (
   path: string,
   configFilename = 'tsconfig.json'
 ): (() => void) => {
-  const cleanupFunctions: (() => void)[] = [];
-
   // Function to register transpiler that returns cleanup function
   let registerTranspiler: () => () => void;
 
   const tsConfigPath = join(path, configFilename);
-  cleanupFunctions.push(registerTsConfigPaths(tsConfigPath));
+  const cleanupFunctions = [registerTsConfigPaths(tsConfigPath)];
 
   const swcNodeInstalled = packageIsInstalled('@swc-node/register');
   if (swcNodeInstalled) {
@@ -50,7 +48,7 @@ export const registerTsProject = (
             module: 'commonjs',
           },
         });
-        return () => {};
+        return () => { };
       };
     }
   }
@@ -94,7 +92,7 @@ export function registerTsConfigPaths(tsConfigPath): () => void {
   } catch (err) {
     warnNoTsconfigPaths();
   }
-  return () => {};
+  return () => { };
 }
 
 function warnTsNodeUsage() {