feat(react): add skipPackageJson flag (#12919)

docs/generated/packages/react.json

@@ -43,6 +43,11 @@
             "type": "boolean",
             "default": false
           },
+          "skipPackageJson": {
+            "description": "Do not add dependencies to `package.json`.",
+            "type": "boolean",
+            "default": false
+          },
           "js": {
             "type": "boolean",
             "default": false,
@@ -390,6 +395,11 @@
             "enum": ["babel", "swc"],
             "default": "babel",
             "description": "Which compiler to use."
+          },
+          "skipPackageJson": {
+            "description": "Do not add dependencies to `package.json`.",
+            "type": "boolean",
+            "default": false
           }
         },
         "required": ["name"],

docs/generated/packages/web.json

@@ -48,6 +48,11 @@
             "description": "Skip formatting files",
             "type": "boolean",
             "default": false
+          },
+          "skipPackageJson": {
+            "description": "Do not add dependencies to `package.json`.",
+            "type": "boolean",
+            "default": false
           }
         },
         "required": [],

packages/react/src/generators/init/init.ts

@@ -82,8 +82,10 @@ export async function reactInitGenerator(host: Tree, schema: InitSchema) {
 
   const initTask = await webInitGenerator(host, schema);
   tasks.push(initTask);
-  const installTask = updateDependencies(host);
-  tasks.push(installTask);
+  if (!schema.skipPackageJson) {
+    const installTask = updateDependencies(host);
+    tasks.push(installTask);
+  }
 
   return runTasksInSerial(...tasks);
 }

packages/react/src/generators/init/schema.d.ts

@@ -2,5 +2,6 @@ export interface InitSchema {
   unitTestRunner?: 'jest' | 'none';
   e2eTestRunner?: 'cypress' | 'none';
   skipFormat?: boolean;
+  skipPackageJson?: boolean;
   js?: boolean;
 }

packages/react/src/generators/init/schema.json

@@ -23,6 +23,11 @@
       "type": "boolean",
       "default": false
     },
+    "skipPackageJson": {
+      "description": "Do not add dependencies to `package.json`.",
+      "type": "boolean",
+      "default": false
+    },
     "js": {
       "type": "boolean",
       "default": false,

packages/react/src/generators/library/library.spec.ts

@@ -6,7 +6,10 @@ import {
   Tree,
   updateJson,
 } from '@nrwl/devkit';
-import { createTreeWithEmptyV1Workspace } from '@nrwl/devkit/testing';
+import {
+  createTreeWithEmptyV1Workspace,
+  createTreeWithEmptyWorkspace,
+} from '@nrwl/devkit/testing';
 import { Linter } from '@nrwl/linter';
 import applicationGenerator from '../application/application';
 import libraryGenerator from './library';
@@ -714,6 +717,24 @@ describe('lib', () => {
     });
   });
 
+  describe('--skipPackageJson', () => {
+    it('should not add dependencies to package.json when true', async () => {
+      // ARRANGE
+      const tree = createTreeWithEmptyWorkspace();
+      const packageJsonBeforeGenerator = tree.read('package.json', 'utf-8');
+      // ACT
+      await libraryGenerator(tree, {
+        ...defaultSchema,
+        skipPackageJson: true,
+      });
+
+      // ASSERT
+      expect(tree.read('package.json', 'utf-8')).toEqual(
+        packageJsonBeforeGenerator
+      );
+    });
+  });
+
   it.each`
     style
     ${'styled-components'}

packages/react/src/generators/library/library.ts

@@ -120,15 +120,17 @@ export async function libraryGenerator(host: Tree, schema: Schema) {
     updateLibPackageNpmScope(host, options);
   }
 
-  const installTask = await addDependenciesToPackageJson(
-    host,
-    {
-      react: reactVersion,
-      'react-dom': reactDomVersion,
-    },
-    options.compiler === 'swc' ? { '@swc/core': swcCoreVersion } : {}
-  );
-  tasks.push(installTask);
+  if (!options.skipPackageJson) {
+    const installTask = await addDependenciesToPackageJson(
+      host,
+      {
+        react: reactVersion,
+        'react-dom': reactDomVersion,
+      },
+      options.compiler === 'swc' ? { '@swc/core': swcCoreVersion } : {}
+    );
+    tasks.push(installTask);
+  }
 
   const routeTask = updateAppRoutes(host, options);
   tasks.push(routeTask);
@@ -150,6 +152,7 @@ async function addLinting(host: Tree, options: NormalizedSchema) {
     unitTestRunner: options.unitTestRunner,
     eslintFilePatterns: [`${options.projectRoot}/**/*.{ts,tsx,js,jsx}`],
     skipFormat: true,
+    skipPackageJson: options.skipPackageJson,
   });
 
   const reactEslintJson = createReactEslintJson(
@@ -163,11 +166,14 @@ async function addLinting(host: Tree, options: NormalizedSchema) {
     () => reactEslintJson
   );
 
-  const installTask = await addDependenciesToPackageJson(
-    host,
-    extraEslintDependencies.dependencies,
-    extraEslintDependencies.devDependencies
-  );
+  let installTask = () => {};
+  if (!options.skipPackageJson) {
+    installTask = await addDependenciesToPackageJson(
+      host,
+      extraEslintDependencies.dependencies,
+      extraEslintDependencies.devDependencies
+    );
+  }
 
   return runTasksInSerial(lintTask, installTask);
 }

packages/react/src/generators/library/schema.d.ts

@@ -23,4 +23,5 @@ export interface Schema {
   setParserOptionsProject?: boolean;
   standaloneConfig?: boolean;
   compiler?: 'babel' | 'swc';
+  skipPackageJson?: boolean;
 }

packages/react/src/generators/library/schema.json

@@ -161,6 +161,11 @@
       "enum": ["babel", "swc"],
       "default": "babel",
       "description": "Which compiler to use."
+    },
+    "skipPackageJson": {
+      "description": "Do not add dependencies to `package.json`.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": ["name"]

packages/web/src/generators/init/init.ts

@@ -65,15 +65,21 @@ export async function webInitGenerator(tree: Tree, schema: Schema) {
   let tasks: GeneratorCallback[] = [];
 
   if (!schema.unitTestRunner || schema.unitTestRunner === 'jest') {
-    const jestTask = jestInitGenerator(tree, {});
+    const jestTask = jestInitGenerator(tree, {
+      skipPackageJson: schema.skipPackageJson,
+    });
     tasks.push(jestTask);
   }
   if (!schema.e2eTestRunner || schema.e2eTestRunner === 'cypress') {
-    const cypressTask = cypressInitGenerator(tree, {});
+    const cypressTask = cypressInitGenerator(tree, {
+      skipPackageJson: schema.skipPackageJson,
+    });
     tasks.push(cypressTask);
   }
-  const installTask = updateDependencies(tree, schema);
-  tasks.push(installTask);
+  if (!schema.skipPackageJson) {
+    const installTask = updateDependencies(tree, schema);
+    tasks.push(installTask);
+  }
   initRootBabelConfig(tree);
   if (!schema.skipFormat) {
     await formatFiles(tree);

packages/web/src/generators/init/schema.d.ts

@@ -3,4 +3,5 @@ export interface Schema {
   unitTestRunner?: 'jest' | 'none';
   e2eTestRunner?: 'cypress' | 'none';
   skipFormat?: boolean;
+  skipPackageJson?: boolean;
 }

packages/web/src/generators/init/schema.json

@@ -28,6 +28,11 @@
       "description": "Skip formatting files",
       "type": "boolean",
       "default": false
+    },
+    "skipPackageJson": {
+      "description": "Do not add dependencies to `package.json`.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": []