fix(js): return empty array if no helper dependencies found (#10582)

* fix(js): return empty array if no helper dependencies found * chore(js): add test for generate package json with helper dependency
nrwl · Jun 4, 2022 · 5daeaf8 · 5daeaf8
1 parent 26177d1
commit 5daeaf8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/e2e/node/src/node.test.ts b/e2e/node/src/node.test.ts
@@ -260,7 +260,7 @@ describe('Build Node apps', () => {
   beforeEach(() => newProject());
 
   it('should generate a package.json with the `--generatePackageJson` flag', async () => {
-    newProject();
+    const scope = newProject();
     const nestapp = uniq('nestapp');
     runCLI(`generate @nrwl/nest:app ${nestapp} --linter=eslint`);
 
@@ -284,6 +284,29 @@ describe('Build Node apps', () => {
         version: '0.0.1',
       })
     );
+
+    const nodeapp = uniq('nodeapp');
+    runCLI(`generate @nrwl/node:app ${nodeapp}`);
+
+    const jslib = uniq('jslib');
+    runCLI(`generate @nrwl/js:lib ${jslib} --buildable`);
+
+    updateFile(
+      `apps/${nodeapp}/src/main.ts`,
+      `
+import { ${jslib} } from '@${scope}/${jslib}';   
+console.log('Hello World!');
+${jslib}();
+`
+    );
+
+    await runCLIAsync(`build ${nodeapp} --generate-package-json`);
+    checkFilesExist(`dist/apps/${nestapp}/package.json`);
+    const nodeAppPackageJson = JSON.parse(
+      readFile(`dist/apps/${nodeapp}/package.json`)
+    );
+
+    expect(nodeAppPackageJson['dependencies']['tslib']).toBeTruthy();
   }, 300000);
 
   describe('NestJS', () => {

diff --git a/packages/js/src/utils/compiler-helper-dependency.ts b/packages/js/src/utils/compiler-helper-dependency.ts
@@ -103,7 +103,7 @@ export function getHelperDependenciesFromProjectGraph(
     !projectGraph.dependencies[sourceProject] ||
     !projectGraph.dependencies[sourceProject].length
   )
-    return;
+    return [];
 
   const sourceDependencies = projectGraph.dependencies[sourceProject];
   const internalDependencies = sourceDependencies.reduce(