Skip to content

Commit

Permalink
fix(release): only early exit when no changelog changes if expecting …
Browse files Browse the repository at this point in the history
…commit (#20568)
  • Loading branch information
JamesHenry committed Dec 5, 2023
1 parent eb48151 commit 5e174fc
Showing 1 changed file with 23 additions and 2 deletions.
25 changes: 23 additions & 2 deletions packages/nx/src/command-line/release/changelog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,14 @@ async function applyChangesAndExit(
let latestCommit = toSHA;

const changes = tree.listChanges();
// This could happen we using conventional commits, for example
if (!changes.length) {

/**
* In the case where we are expecting changelog file updates, but there is nothing
* to flush from the tree, we exit early. This could happen we using conventional
* commits, for example.
*/
const changelogFilesEnabled = checkChangelogFilesEnabled(nxReleaseConfig);
if (changelogFilesEnabled && !changes.length) {
output.warn({
title: `No changes detected for changelogs`,
bodyLines: [
Expand Down Expand Up @@ -897,3 +903,18 @@ async function generateChangelogForProjects(
printSummary();
}
}

function checkChangelogFilesEnabled(nxReleaseConfig: NxReleaseConfig): boolean {
if (
nxReleaseConfig.changelog.workspaceChangelog &&
nxReleaseConfig.changelog.workspaceChangelog.file
) {
return true;
}
for (const releaseGroup of Object.values(nxReleaseConfig.groups)) {
if (releaseGroup.changelog && releaseGroup.changelog.file) {
return true;
}
}
return false;
}

0 comments on commit 5e174fc

Please sign in to comment.