Skip to content

Commit

Permalink
fix(react): remove collected dependency from module federation shared…
Browse files Browse the repository at this point in the history
… config when not found in package.json (#10157)
  • Loading branch information
leosvelperez committed May 5, 2022
1 parent b8c175f commit 67e233d
Showing 1 changed file with 18 additions and 7 deletions.
25 changes: 18 additions & 7 deletions packages/react/src/module-federation/webpack-utils.ts
@@ -1,6 +1,6 @@
import { existsSync, readFileSync } from 'fs';
import { NormalModuleReplacementPlugin } from 'webpack';
import { joinPathFragments, normalizePath, workspaceRoot } from '@nrwl/devkit';
import { joinPathFragments, logger, workspaceRoot } from '@nrwl/devkit';
import { dirname, join, normalize } from 'path';
import { ParsedCommandLine } from 'typescript';
import {
Expand Down Expand Up @@ -87,15 +87,26 @@ export function sharePackages(

const pkgJson = JSON.parse(readFileSync(pkgJsonPath, 'utf-8'));

return packages.reduce(
(shared, pkgName) => ({
return packages.reduce((shared, pkgName) => {
const version =
pkgJson.dependencies?.[pkgName] ?? pkgJson.devDependencies?.[pkgName];
if (!version) {
logger.warn(
`Could not find a version for "${pkgName}" in the root "package.json" ` +
'when collecting shared packages for the Module Federation setup. ' +
'The package will not be shared.'
);

return shared;
}

return {
...shared,
[pkgName]: {
singleton: true,
strictVersion: true,
requiredVersion: pkgJson.dependencies[pkgName],
requiredVersion: version,
},
}),
{}
);
};
}, {});
}

0 comments on commit 67e233d

Please sign in to comment.