fix(js): add "dts" flag to swc executor

nrwl · Feb 22, 2022 · 6e170aa · 6e170aa
1 parent 6861fa9
commit 6e170aa
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/docs/generated/api-js/executors/swc.md b/docs/generated/api-js/executors/swc.md
@@ -35,6 +35,14 @@ Type: `array`
 
 List of static assets.
 
+### dts
+
+Default: `true`
+
+Type: `boolean`
+
+Whether to emit Type Declarations using tsc.
+
 ### skipTypeCheck
 
 Default: `false`

diff --git a/packages/js/src/executors/swc/schema.json b/packages/js/src/executors/swc/schema.json
@@ -35,6 +35,11 @@
       "description": "Whether to skip TypeScript type checking.",
       "default": false
     },
+    "dts": {
+      "type": "boolean",
+      "description": "Whether to emit Type Declarations using tsc.",
+      "default": true
+    },
     "swcExclude": {
       "type": "array",
       "description": "List of SWC Glob/Regex to be excluded from compilation (https://swc.rs/docs/configuration/compilation#exclude)",

diff --git a/packages/js/src/executors/swc/swc.impl.ts b/packages/js/src/executors/swc/swc.impl.ts
@@ -1,4 +1,4 @@
-import { ExecutorContext } from '@nrwl/devkit';
+import { ExecutorContext, logger } from '@nrwl/devkit';
 import {
   assetGlobsToFiles,
   FileInputOutput,
@@ -25,6 +25,10 @@ function normalizeOptions(
 ): NormalizedSwcExecutorOptions {
   const outputPath = join(contextRoot, options.outputPath);
 
+  if (options.dts == null) {
+    options.dts = true;
+  }
+
   if (options.skipTypeCheck == null) {
     options.skipTypeCheck = false;
   }

diff --git a/packages/js/src/utils/schema.d.ts b/packages/js/src/utils/schema.d.ts
@@ -48,6 +48,7 @@ export interface NormalizedExecutorOptions extends ExecutorOptions {
 
 export interface SwcExecutorOptions extends ExecutorOptions {
   skipTypeCheck?: boolean;
+  dts?: boolean;
   swcExclude?: string[];
 }
 
@@ -61,6 +62,7 @@ export interface NormalizedSwcExecutorOptions
   extends NormalizedExecutorOptions {
   swcExclude: string[];
   skipTypeCheck: boolean;
+  dts: boolean;
   swcCliOptions: SwcCliOptions;
 }
 

diff --git a/packages/js/src/utils/swc/compile-swc.ts b/packages/js/src/utils/swc/compile-swc.ts
@@ -15,10 +15,11 @@ function getSwcCmd(
 }
 
 function getTypeCheckOptions(normalizedOptions: NormalizedSwcExecutorOptions) {
-  const { projectRoot, watch, tsConfig, root, outputPath } = normalizedOptions;
+  const { projectRoot, watch, tsConfig, root, outputPath, dts } =
+    normalizedOptions;
 
   const typeCheckOptions: TypeCheckOptions = {
-    mode: 'emitDeclarationOnly',
+    mode: dts ? 'emitDeclarationOnly' : 'noEmit',
     tsConfigPath: tsConfig,
     outDir: outputPath.replace(`/${projectRoot}`, ''),
     workspaceRoot: root,