fix(core): add migrations to remove root

packages/nx/migrations.json

@@ -1,3 +1,10 @@
 {
-  "migrations": {}
+  "generators": {
+    "14-0-0-remove-root": {
+      "cli": "nx",
+      "version": "14.0.4",
+      "description": "Remove root property from project.json files",
+      "factory": "./src/migrations/update-14-0-4/remove-roots"
+    }
+  }
 }

packages/nx/migrations.spec.ts

@@ -0,0 +1,12 @@
+import path = require('path');
+import json = require('./migrations.json');
+
+describe('Node migrations', () => {
+  it('should have valid paths', () => {
+    Object.values(json.generators).forEach((m) => {
+      expect(() =>
+        require.resolve(path.join(__dirname, `${m.factory}.ts`))
+      ).not.toThrow();
+    });
+  });
+});

packages/nx/src/generators/internal-utils/format-changed-with-prettier-if-available.ts → packages/nx/src/generators/internal-utils/format-changed-files-with-prettier-if-available.ts

@@ -6,7 +6,7 @@ import type * as Prettier from 'prettier';
  * Formats all the created or updated files using Prettier
  * @param tree - the file system tree
  */
-export async function formatChangedWithPrettierIfAvailable(
+export async function formatChangedFilesWithPrettierIfAvailable(
   tree: Tree
 ): Promise<void> {
   let prettier: typeof Prettier;

packages/nx/src/migrations/update-14-0-4/remove-roots.spec.ts

@@ -0,0 +1,48 @@
+import { Tree } from '../../generators/tree';
+import { createTreeWithEmptyWorkspace } from '../../generators/testing-utils/create-tree-with-empty-workspace';
+import { addProjectConfiguration } from '../../generators/utils/project-configuration';
+import { readJson, updateJson } from '../../generators/utils/json';
+import removeRoots from './remove-roots';
+
+describe('remove-roots >', () => {
+  let tree: Tree;
+
+  describe('projects with project.json configs', () => {
+    beforeEach(() => {
+      tree = createTreeWithEmptyWorkspace(2);
+    });
+
+    it('should remove the root property', async () => {
+      addProjectConfiguration(tree, 'proj1', {
+        root: 'proj1',
+      });
+
+      updateJson(tree, 'proj1/project.json', (config) => ({
+        ...config,
+        root: 'proj1',
+      }));
+
+      await removeRoots(tree);
+
+      expect(readJson(tree, 'proj1/project.json').root).toBeUndefined();
+    });
+  });
+
+  describe('projects with project.json configs', () => {
+    beforeEach(() => {
+      tree = createTreeWithEmptyWorkspace(1);
+    });
+
+    it('should remove the root property', async () => {
+      addProjectConfiguration(tree, 'proj1', {
+        root: 'proj1',
+      });
+
+      await removeRoots(tree);
+
+      expect(readJson(tree, 'workspace.json').projects.proj1.root).toEqual(
+        'proj1'
+      );
+    });
+  });
+});

packages/nx/src/migrations/update-14-0-4/remove-roots.ts

@@ -0,0 +1,15 @@
+import { Tree } from '../../generators/tree';
+import {
+  getProjects,
+  updateProjectConfiguration,
+} from '../../generators/utils/project-configuration';
+import { formatChangedFilesWithPrettierIfAvailable } from '../../generators/internal-utils/format-changed-files-with-prettier-if-available';
+
+export default async function (tree: Tree) {
+  // This looks like it does nothing, but this will actually effectively migrate over all the configs that need to be moved over, but won't touch configs that don't need to be moved
+  for (const [projName, projConfig] of getProjects(tree)) {
+    updateProjectConfiguration(tree, projName, projConfig);
+  }
+
+  await formatChangedFilesWithPrettierIfAvailable(tree);
+}