fix(core): add project.json to nx implicit dependencies

nrwl · Feb 3, 2022 · 8567ca4 · 8567ca4
1 parent da64519
commit 8567ca4
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 18 deletions.
diff --git a/packages/workspace/presets/core.json b/packages/workspace/presets/core.json
@@ -4,7 +4,8 @@
       "dependencies": "*",
       "devDependencies": "*"
     },
-    ".eslintrc.json": "*"
+    ".eslintrc.json": "*",
+    "packages/**/project.json": "*"
   },
   "targetDependencies": {
     "build": [

diff --git a/packages/workspace/presets/npm.json b/packages/workspace/presets/npm.json
@@ -4,7 +4,8 @@
       "dependencies": "*",
       "devDependencies": "*"
     },
-    ".eslintrc.json": "*"
+    ".eslintrc.json": "*",
+    "packages/**/project.json": "*"
   },
   "targetDependencies": {
     "build": [

diff --git a/packages/workspace/src/command-line/run-one.ts b/packages/workspace/src/command-line/run-one.ts
@@ -27,7 +27,7 @@ export async function runOne(opts: {
   await connectToNxCloudUsingScan(nxArgs.scan);
 
   const projectGraph = await createProjectGraphAsync();
-  const { projects, projectsMap } = getProjects(projectGraph, opts.project);
+  const { projects } = getProjects(projectGraph, opts.project);
   const env = readEnvironment();
 
   await runCommand(

diff --git a/packages/workspace/src/generators/new/__snapshots__/new.spec.ts.snap b/packages/workspace/src/generators/new/__snapshots__/new.spec.ts.snap
@@ -82,6 +82,8 @@ Object {
   },
   "implicitDependencies": Object {
     ".eslintrc.json": "*",
+    "apps/**/project.json": "*",
+    "libs/**/project.json": "*",
     "package.json": Object {
       "dependencies": "*",
       "devDependencies": "*",

diff --git a/packages/workspace/src/generators/workspace/files/nx.json__tmpl__ b/packages/workspace/src/generators/workspace/files/nx.json__tmpl__
@@ -12,7 +12,9 @@
       "dependencies": "*",
       "devDependencies": "*"
     },
-    ".eslintrc.json": "*"
+    ".eslintrc.json": "*",
+    "apps/**/project.json": "*",
+    "libs/**/project.json": "*"
   },
   "tasksRunnerOptions": {
     "default": {

diff --git a/packages/workspace/src/generators/workspace/workspace.spec.ts b/packages/workspace/src/generators/workspace/workspace.spec.ts
@@ -48,6 +48,8 @@ describe('@nrwl/workspace:workspace', () => {
           devDependencies: '*',
         },
         '.eslintrc.json': '*',
+        'apps/**/project.json': '*',
+        'libs/**/project.json': '*',
       },
       tasksRunnerOptions: {
         default: {
@@ -123,14 +125,14 @@ describe('@nrwl/workspace:workspace', () => {
 
     const { scripts } = readJson(tree, '/proj/package.json');
     expect(scripts).toMatchInlineSnapshot(`
-Object {
-  "build": "nx build",
-  "ng": "nx",
-  "postinstall": "node ./decorate-angular-cli.js",
-  "start": "nx serve",
-  "test": "nx test",
-}
-`);
+      Object {
+        "build": "nx build",
+        "ng": "nx",
+        "postinstall": "node ./decorate-angular-cli.js",
+        "start": "nx serve",
+        "test": "nx test",
+      }
+    `);
   });
 
   it('should not add decorate-angular-cli when used with nx cli', async () => {
@@ -145,12 +147,12 @@ Object {
 
     const { scripts } = readJson(tree, '/proj/package.json');
     expect(scripts).toMatchInlineSnapshot(`
-Object {
-  "build": "nx build",
-  "start": "nx serve",
-  "test": "nx test",
-}
-`);
+      Object {
+        "build": "nx build",
+        "start": "nx serve",
+        "test": "nx test",
+      }
+    `);
   });
 
   it('should create a workspace using package layout', async () => {