fix(core): esbuild generateLockfile according to docs (#18413)

nrwl · Aug 1, 2023 · a5d6a29 · a5d6a29 · vercel · Aug 1, 2023
1 parent 48deaec
commit a5d6a29
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/e2e/esbuild/src/esbuild.test.ts b/e2e/esbuild/src/esbuild.test.ts
@@ -51,7 +51,10 @@ describe('EsBuild Plugin', () => {
 
     expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/);
     // main field should be set correctly in package.json
-    checkFilesExist(`dist/libs/${myPkg}/package.json`);
+    checkFilesExist(
+      `dist/libs/${myPkg}/package.json`,
+      `dist/libs/${myPkg}/pnpm-lock.yaml`
+    );
     expect(runCommand(`node dist/libs/${myPkg}`)).toMatch(/Hello/);
 
     expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/);

diff --git a/packages/esbuild/src/executors/esbuild/esbuild.impl.ts b/packages/esbuild/src/executors/esbuild/esbuild.impl.ts
@@ -85,6 +85,7 @@ export async function* esbuildExecutor(
       ...options,
       // TODO(jack): make types generate with esbuild
       skipTypings: true,
+      generateLockfile: true,
       outputFileExtensionForCjs: getOutExtension('cjs', options),
       excludeLibsInPackageJson: !options.thirdParty,
       updateBuildableProjectDepsInPackageJson: externalDependencies.length > 0,