fix(core): targets referred to by targetDependencies should be option…

…al by default
nrwl · Mar 15, 2022 · a6983ad · a6983ad
1 parent 9c25cd9
commit a6983ad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/packages/workspace/src/tasks-runner/run-command.ts b/packages/workspace/src/tasks-runner/run-command.ts
@@ -3,6 +3,7 @@ import { join } from 'path';
 import { appRootPath } from 'nx/src/utils/app-root';
 import type {
   NxJsonConfiguration,
+  ProjectConfiguration,
   ProjectGraph,
   ProjectGraphProjectNode,
   TargetDependencyConfig,
@@ -347,7 +348,7 @@ export function createTask({
 }
 
 function addTasksForProjectDependencyConfig(
-  project: ProjectGraphProjectNode,
+  project: ProjectGraphProjectNode<ProjectConfiguration>,
   {
     target,
     configuration,
@@ -387,10 +388,9 @@ function addTasksForProjectDependencyConfig(
         const depProject = projectGraph.nodes[
           dep.target
         ] as ProjectGraphProjectNode;
-        if (
-          depProject &&
-          projectHasTarget(depProject, dependencyConfig.target)
-        ) {
+        const hasTarget =
+          depProject && projectHasTarget(depProject, dependencyConfig.target);
+        if (depProject && hasTarget) {
           addTasksForProjectTarget(
             {
               project: depProject,
@@ -428,7 +428,7 @@ function addTasksForProjectDependencyConfig(
         }
       }
     }
-  } else {
+  } else if (project.data.targets[dependencyConfig.target]) {
     addTasksForProjectTarget(
       {
         project,

diff --git a/packages/workspace/src/tasks-runner/task-graph-creator.ts b/packages/workspace/src/tasks-runner/task-graph-creator.ts
@@ -55,7 +55,10 @@ export class TaskGraphCreator {
         for (const t of tasks) {
           if (
             t.target.project === task.target.project &&
-            t.target.target === dependencyConfig.target
+            t.target.target === dependencyConfig.target &&
+            this.projectGraph.nodes[t.target.project]?.data?.targets[
+              t.target.target
+            ]
           ) {
             graph.dependencies[task.id].push(t.id);
           }