fix(angular): ajv hoisting issue

chore(angular): update webpack ignored deps
nrwl · Feb 6, 2024 · ac7f2cc · ac7f2cc
1 parent 9046eef
commit ac7f2cc
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/e2e/angular-core/src/projects.test.ts b/e2e/angular-core/src/projects.test.ts
@@ -218,8 +218,7 @@ describe('Angular Projects', () => {
     removeFile(`${app1}/src/app/inline-template.component.ts`);
   }, 1000000);
 
-  // TODO(crystal, @jaysoo): enable this test when buildable libs work
-  xit('should build the dependent buildable lib and its child lib, as well as the app', async () => {
+  it('should build the dependent buildable lib and its child lib, as well as the app', async () => {
     // ARRANGE
     const buildableLib = uniq('buildlib1');
     const buildableChildLib = uniq('buildlib2');

diff --git a/packages/angular/src/builders/webpack-browser/webpack-browser.impl.ts b/packages/angular/src/builders/webpack-browser/webpack-browser.impl.ts
@@ -103,7 +103,7 @@ export function executeWebpackBrowserBuilder(
     switchMap(({ executeBrowserBuilder }) =>
       executeBrowserBuilder(delegateBuilderOptions, context as any, {
         webpackConfiguration: (baseWebpackConfig) => {
-          if (!buildLibsFromSource && delegateBuilderOptions.watch) {
+          if (!buildLibsFromSource) {
             const workspaceDependencies = dependencies
               .filter((dep) => !isNpmProject(dep.node))
               .map((dep) => dep.node.name);

diff --git a/packages/next/package.json b/packages/next/package.json
@@ -49,6 +49,7 @@
     "@nx/eslint": "file:../eslint",
     "@nx/react": "file:../react",
     "@nx/web": "file:../web",
+    "@nx/webpack": "file:../webpack",
     "@nx/workspace": "file:../workspace"
   },
   "publishConfig": {

diff --git a/packages/webpack/.eslintrc.json b/packages/webpack/.eslintrc.json
@@ -46,7 +46,8 @@
               "source-map-loader",
               "swc-loader",
               "@swc/core",
-              "ts-loader"
+              "ts-loader",
+              "ajv"
             ]
           }
         ]

diff --git a/packages/webpack/package.json b/packages/webpack/package.json
@@ -30,6 +30,7 @@
   },
   "dependencies": {
     "@babel/core": "^7.23.2",
+    "ajv": "^8.12.0",
     "autoprefixer": "^10.4.9",
     "babel-loader": "^9.1.2",
     "browserslist": "^4.21.4",