fix(core): inotify error does not propagate correctly

nrwl · Oct 24, 2022 · b403017 · b403017
1 parent 5837715
commit b403017
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/packages/nx/src/daemon/server/server.ts b/packages/nx/src/daemon/server/server.ts
@@ -323,7 +323,7 @@ export async function startServer(): Promise<Server> {
 
           return resolve(server);
         } catch (err) {
-          reject(err);
+          await handleWorkspaceChanges(err, []);
         }
       });
     } catch (err) {

diff --git a/packages/nx/src/project-graph/project-graph.ts b/packages/nx/src/project-graph/project-graph.ts
@@ -136,10 +136,6 @@ export async function createProjectGraphAsync(
       }
       return await daemonClient.getProjectGraph();
     } catch (e) {
-      if (!e.internalDaemonError) {
-        handleProjectGraphError(opts, e);
-      }
-
       if (e.message.indexOf('inotify_add_watch') > -1) {
         // common errors with the daemon due to OS settings (cannot watch all the files available)
         output.note({
@@ -149,7 +145,11 @@ export async function createProjectGraphAsync(
             'Nx Daemon is going to be disabled until you run "nx reset".',
           ],
         });
-      } else {
+        markDaemonAsDisabled();
+        return buildProjectGraphWithoutDaemon();
+      }
+
+      if (e.internalDaemonError) {
         const errorLogFile = writeDaemonLogs(e.message);
         output.warn({
           title: `Nx Daemon was not able to compute the project graph.`,
@@ -159,9 +159,11 @@ export async function createProjectGraphAsync(
             'Nx Daemon is going to be disabled until you run "nx reset".',
           ],
         });
+        markDaemonAsDisabled();
+        return buildProjectGraphWithoutDaemon();
       }
-      markDaemonAsDisabled();
-      return buildProjectGraphWithoutDaemon();
+
+      handleProjectGraphError(opts, e);
     }
   }
 }