fix(core): fix print-affected not filtering on target (#12355)

Co-authored-by: Jason Jean <jasonjean1993@gmail.com>

e2e/nx-run/src/affected-graph.test.ts

@@ -333,26 +333,23 @@ describe('Nx Affected and Graph Tests', () => {
         command: `${runNx} run ${myapp}:test`,
         outputs: [`coverage/apps/${myapp}`],
       });
-      compareTwoArrays(resWithTarget.projects, [`${myapp}-e2e`, myapp]);
+      compareTwoArrays(resWithTarget.projects, [myapp]);
 
       const resWithTargetWithSelect1 = (
         await runCLIAsync(
           `print-affected --files=apps/${myapp}/src/app/app.element.spec.ts --target=test --select=projects`,
           { silent: true }
         )
       ).stdout.trim();
-      compareTwoSerializedArrays(
-        resWithTargetWithSelect1,
-        `${myapp}-e2e, ${myapp}`
-      );
+      compareTwoSerializedArrays(resWithTargetWithSelect1, myapp);
 
       const resWithTargetWithSelect2 = (
         await runCLIAsync(
           `print-affected --files=apps/${myapp}/src/app.element.spec.ts --target=test --select="tasks.target.project"`,
           { silent: true }
         )
       ).stdout.trim();
-      compareTwoSerializedArrays(resWithTargetWithSelect2, `${myapp}`);
+      compareTwoSerializedArrays(resWithTargetWithSelect2, myapp);
     }, 120000);
 
     function compareTwoSerializedArrays(a: string, b: string) {

packages/nx/src/command-line/affected.ts

@@ -94,18 +94,15 @@ export async function affected(
 
       case 'print-affected':
         if (nxArgs.target) {
-          const projectsWithTarget = allProjectsWithTarget(projects, nxArgs);
           await printAffected(
-            projectsWithTarget,
-            projects,
+            allProjectsWithTarget(projects, nxArgs),
             projectGraph,
             { nxJson },
             nxArgs,
             overrides
           );
         } else {
           await printAffected(
-            [],
             projects,
             projectGraph,
             { nxJson },

packages/nx/src/command-line/print-affected.ts

@@ -12,25 +12,25 @@ import { workspaceRoot } from '../utils/workspace-root';
 import { getPackageManagerCommand } from 'nx/src/utils/package-manager';
 
 export async function printAffected(
-  affectedProjectsWithTargetAndConfig: ProjectGraphProjectNode[],
   affectedProjects: ProjectGraphProjectNode[],
   projectGraph: ProjectGraph,
   { nxJson }: { nxJson: NxJsonConfiguration },
   nxArgs: NxArgs,
   overrides: yargs.Arguments
 ) {
-  const projectNames = affectedProjects
-    .filter((p) => (nxArgs.type ? p.type === nxArgs.type : true))
-    .map((p) => p.name);
-  const tasksJson = await createTasks(
-    affectedProjectsWithTargetAndConfig.filter((p) =>
-      nxArgs.type ? p.type === nxArgs.type : true
-    ),
-    projectGraph,
-    nxArgs,
-    nxJson,
-    overrides
+  const projectsForType = affectedProjects.filter((p) =>
+    nxArgs.type ? p.type === nxArgs.type : true
   );
+  const projectNames = projectsForType.map((p) => p.name);
+  const tasksJson = nxArgs.target
+    ? await createTasks(
+        projectsForType,
+        projectGraph,
+        nxArgs,
+        nxJson,
+        overrides
+      )
+    : [];
   const result = {
     tasks: tasksJson,
     projects: projectNames,