fix(testing): add root karma config if one isn't present when using k…

…arma-project generator when using the karma-project generator directory ensure the karma generator (install deps/root config) is called if the root karma config isn't present ISSUES CLOSED: #9234
nrwl · Mar 23, 2022 · e0ecb96 · e0ecb96
1 parent d5102f0
commit e0ecb96
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/docs/generated/api-angular/generators/karma-project.md b/docs/generated/api-angular/generators/karma-project.md
@@ -42,3 +42,11 @@ Default: `false`
 Type: `boolean`
 
 Skip formatting files.
+
+### skipPackageJson
+
+Default: `false`
+
+Type: `boolean`
+
+Skip updating package.json.
diff --git a/packages/angular/src/generators/karma-project/karma-project.spec.ts b/packages/angular/src/generators/karma-project/karma-project.spec.ts
@@ -41,11 +41,13 @@ describe('karmaProject', () => {
   });
 
   it('should generate files', async () => {
+    expect(tree.exists('karma.conf.js')).toBeFalsy();
     await karmaProjectGenerator(tree, { project: 'lib1' });
 
     expect(tree.exists('/libs/lib1/karma.conf.js')).toBeTruthy();
     expect(tree.exists('/libs/lib1/tsconfig.spec.json')).toBeTruthy();
     expect(tree.exists('/libs/lib1/src/test.ts')).toBeTruthy();
+    expect(tree.exists('karma.conf.js')).toBeTruthy();
   });
 
   it('should create a karma.conf.js', async () => {

diff --git a/packages/angular/src/generators/karma-project/karma-project.ts b/packages/angular/src/generators/karma-project/karma-project.ts
@@ -5,11 +5,15 @@ import { generateKarmaProjectFiles } from './lib/generate-karma-project-files';
 import { updateTsConfigs } from './lib/update-tsconfig';
 import { updateWorkspaceConfig } from './lib/update-workspace-config';
 import type { KarmaProjectOptions } from './schema';
+import { karmaGenerator } from '../karma/karma';
 
 export async function karmaProjectGenerator(
   tree: Tree,
   options: KarmaProjectOptions
 ) {
+  if (!tree.exists('karma.conf.js')) {
+    karmaGenerator(tree, options);
+  }
   checkProjectTestTarget(tree, options.project);
   generateKarmaProjectFiles(tree, options.project);
   updateTsConfigs(tree, options.project);

diff --git a/packages/angular/src/generators/karma-project/schema.d.ts b/packages/angular/src/generators/karma-project/schema.d.ts
@@ -1,4 +1,5 @@
 export interface KarmaProjectOptions {
   project: string;
   skipFormat?: boolean;
+  skipPackageJson?: boolean;
 }
diff --git a/packages/angular/src/generators/karma-project/schema.json b/packages/angular/src/generators/karma-project/schema.json
@@ -16,6 +16,11 @@
       "description": "Skip formatting files.",
       "type": "boolean",
       "default": false
+    },
+    "skipPackageJson": {
+      "description": "Skip updating package.json.",
+      "type": "boolean",
+      "default": false
     }
   },
   "additionalProperties": false,