fix(core): calculate dependencies of mixed targets (#9942)

nrwl · Apr 27, 2022 · e3817ef · e3817ef · vercel · Apr 27, 2022
1 parent 5e124ee
commit e3817ef
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/packages/nx/src/tasks-runner/run-command.ts b/packages/nx/src/tasks-runner/run-command.ts
@@ -368,7 +368,7 @@ function addTasksForProjectDependencyConfig(
   };
 
   const newPath = [...path, pathFragment];
-  seenSet.add(project.name);
+  seenSet.add(targetIdentifier);
 
   if (tasksMap.has(targetIdentifier)) {
     return;
@@ -388,11 +388,11 @@ function addTasksForProjectDependencyConfig(
         ) {
           const depTargetId = getId({
             project: depProject.name,
-            target,
+            target: dependencyConfig.target,
             configuration: configuration,
           });
           exitOnCircularDep(newPath, depTargetId);
-          if (seenSet.has(dep.target)) {
+          if (seenSet.has(depTargetId)) {
             continue;
           }
 
@@ -413,18 +413,17 @@ function addTasksForProjectDependencyConfig(
           );
         } else {
           if (!depProject) {
-            seenSet.add(dep.target);
             continue;
           }
           const depTargetId = getId({
             project: depProject.name,
-            target,
+            target: dependencyConfig.target,
             configuration: configuration,
           });
 
           exitOnCircularDep(newPath, depTargetId);
 
-          if (seenSet.has(dep.target)) {
+          if (seenSet.has(depTargetId)) {
             continue;
           }