Skip to content

Commit

Permalink
fix(js): append target when generating tmp tsconfig to prevent confli…
Browse files Browse the repository at this point in the history
…cts #21396 (#22671)

(cherry picked from commit 1c6118e)
  • Loading branch information
Coly010 authored and FrozenPandaz committed Apr 5, 2024
1 parent 3134140 commit e4c4697
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion e2e/vite/src/vite-legacy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export default App;
const results = runCLI(`build ${app} --buildLibsFromSource=false`);
expect(results).toContain('Successfully ran target build for project');
// this should be less modules than building from source
expect(results).toContain('38 modules transformed');
expect(results).toContain('40 modules transformed');
});

it('should build app from libs without package.json in lib', () => {
Expand Down
1 change: 1 addition & 0 deletions packages/js/src/utils/buildable-libs-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ export function createTmpTsConfig(
workspaceRoot,
'tmp',
projectRoot,
process.env.NX_TASK_TARGET_TARGET ?? 'build',
'tsconfig.generated.json'
);
const parsedTSConfig = readTsConfigWithRemappedPaths(
Expand Down

0 comments on commit e4c4697

Please sign in to comment.