fix(core): handle failed CI workflows in CNW CLI (#9915)

nrwl · Apr 21, 2022 · ec0f4b4 · ec0f4b4 · vercel · Apr 21, 2022
1 parent b7bf53b
commit ec0f4b4
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/docs/generated/packages/workspace.json b/docs/generated/packages/workspace.json
@@ -684,6 +684,7 @@
             "type": "string",
             "description": "Workflow name.",
             "$default": { "$source": "argv", "index": 0 },
+            "default": "build",
             "x-prompt": "How should we name your workflow?",
             "pattern": "^[a-zA-Z].*$"
           }

diff --git a/packages/create-nx-workspace/bin/create-nx-workspace.ts b/packages/create-nx-workspace/bin/create-nx-workspace.ts
@@ -827,7 +827,7 @@ async function setupCI(
   try {
     const pmc = getPackageManagerCommand(packageManager);
     // GENERATE WORKFLOWS HERE based on `ci` and `packageManager`
-    const res = Promise.allSettled(
+    const res = await Promise.allSettled(
       ci.map(
         async (provider) =>
           await execAndWait(
@@ -836,8 +836,31 @@ async function setupCI(
           )
       )
     );
-    ciSpinner.succeed('CI workflow(s) have been generated successfully');
-    return res;
+    if (res.some((r) => r.status === 'fulfilled')) {
+      if (res.some((r) => r.status === 'rejected')) {
+        // show error message that some failed
+        const failedWorkflows = res
+          .map((r, i) => [r.status, ci[i]])
+          .filter(([r, provider]) => r === 'rejected')
+          .map(([, provider]) => `"${provider}"`)
+          .join(', ');
+        ciSpinner.fail(
+          `Nx failed to generate some CI workflow(s): ${failedWorkflows}`
+        );
+      } else {
+        ciSpinner.succeed('CI workflow(s) have been generated successfully');
+      }
+      return res;
+    } else {
+      ciSpinner.fail();
+
+      output.error({
+        title: `Nx failed to generate CI workflow(s)`,
+        bodyLines: res.map((r: PromiseRejectedResult) => r.reason.message),
+      });
+
+      process.exit(1);
+    }
   } catch (e) {
     ciSpinner.fail();
 

diff --git a/packages/workspace/src/generators/ci-workflow/schema.json b/packages/workspace/src/generators/ci-workflow/schema.json
@@ -27,6 +27,7 @@
         "$source": "argv",
         "index": 0
       },
+      "default": "build",
       "x-prompt": "How should we name your workflow?",
       "pattern": "^[a-zA-Z].*$"
     }