fix(angular): do not configure e2e test runner when generating a libr…

…ary (#10553)
nrwl · Jun 2, 2022 · ec90625 · ec90625
1 parent aecca6b
commit ec90625
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/e2e/angular-core/src/ng-add.test.ts b/e2e/angular-core/src/ng-add.test.ts
@@ -52,7 +52,9 @@ describe('convert Angular CLI workspace to an Nx workspace', () => {
   }
 
   function addCypress() {
-    runNgAdd('@cypress/schematic', '--e2e-update', 'latest');
+    // TODO(leo): @cypress/schematic latest comes with Cypress 10 support
+    // which we don't support yet in our Cypress plugin.
+    runNgAdd('@cypress/schematic', '--e2e-update', '1.7.0');
   }
 
   function addEsLint() {

diff --git a/packages/angular/src/generators/library/library.spec.ts b/packages/angular/src/generators/library/library.spec.ts
@@ -511,6 +511,21 @@ describe('lib', () => {
         ].prefix
       ).toEqual('custom');
     });
+
+    it('should not install any e2e test runners', async () => {
+      // ACT
+      await runLibraryGeneratorWithOpts({
+        publishable: true,
+        importPath: '@myorg/lib',
+      });
+
+      // ASSERT
+      let { dependencies, devDependencies } = readJson(tree, 'package.json');
+      expect(dependencies.cypress).toBeUndefined();
+      expect(devDependencies.cypress).toBeUndefined();
+      expect(dependencies.protractor).toBeUndefined();
+      expect(devDependencies.protractor).toBeUndefined();
+    });
   });
 
   describe('nested', () => {

diff --git a/packages/angular/src/generators/library/library.ts b/packages/angular/src/generators/library/library.ts
@@ -11,6 +11,7 @@ import { jestProjectGenerator } from '@nrwl/jest';
 import { Linter } from '@nrwl/linter';
 import { convertToNxProjectGenerator } from '@nrwl/workspace/generators';
 import init from '../../generators/init/init';
+import { E2eTestRunner } from '../../utils/test-runners';
 import { ngPackagrVersion } from '../../utils/versions';
 import addLintingGenerator from '../add-linting/add-linting';
 import karmaProjectGenerator from '../karma-project/karma-project';
@@ -51,6 +52,7 @@ export async function libraryGenerator(host: Tree, schema: Partial<Schema>) {
   await init(host, {
     ...options,
     skipFormat: true,
+    e2eTestRunner: E2eTestRunner.None,
   });
 
   const runAngularLibrarySchematic = wrapAngularDevkitSchematic(