fix(angular): remove implicit deps creation from mfe (#9799)

nrwl · Apr 13, 2022 · ee4174c · ee4174c
1 parent 0528b03
commit ee4174c
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 42 deletions.
diff --git a/packages/angular/src/generators/setup-mfe/lib/add-implicit-deps.ts b/packages/angular/src/generators/setup-mfe/lib/add-implicit-deps.ts
diff --git a/packages/angular/src/generators/setup-mfe/lib/index.ts b/packages/angular/src/generators/setup-mfe/lib/index.ts
@@ -1,6 +1,5 @@
 export * from './add-cypress-workaround';
 export * from './add-entry-module';
-export * from './add-implicit-deps';
 export * from './add-remote-to-host';
 export * from './change-build-target';
 export * from './fix-bootstrap';

diff --git a/packages/angular/src/generators/setup-mfe/setup-mfe.spec.ts b/packages/angular/src/generators/setup-mfe/setup-mfe.spec.ts
@@ -135,22 +135,6 @@ describe('Init MFE', () => {
 
     expect(mfeConfigContents).toContain(`'remote1'`);
   });
-  it('should update the implicit dependencies of the host when --remotes flag supplied', async () => {
-    // ACT
-    await setupMfe(tree, {
-      appName: 'app1',
-      mfeType: 'host',
-      remotes: ['remote1'],
-    });
-
-    // ASSERT
-    const projectConfig: ProjectConfiguration = readProjectConfiguration(
-      tree,
-      'app1'
-    );
-
-    expect(projectConfig.implicitDependencies).toContain('remote1');
-  });
 
   it('should add a remote application and add it to a specified host applications webpack config when no other remote has been added to it', async () => {
     // ARRANGE

diff --git a/packages/angular/src/generators/setup-mfe/setup-mfe.ts b/packages/angular/src/generators/setup-mfe/setup-mfe.ts
@@ -6,7 +6,6 @@ import { readProjectConfiguration, formatFiles } from '@nrwl/devkit';
 import {
   addCypressOnErrorWorkaround,
   addEntryModule,
-  addImplicitDeps,
   addRemoteToHost,
   changeBuildTarget,
   fixBootstrap,
@@ -30,7 +29,6 @@ export async function setupMfe(tree: Tree, options: Schema) {
   generateWebpackConfig(tree, options, projectConfig.root, remotesWithPorts);
 
   addEntryModule(tree, options, projectConfig.root);
-  addImplicitDeps(tree, options);
   changeBuildTarget(tree, options);
   updateTsConfigTarget(tree, options);
   setupServeTarget(tree, options);