feat(vite): more tests

packages/vite/src/migrations/update-17-2-0/add-vite-plugin.spec.ts

@@ -1,17 +1,74 @@
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
-import { Tree } from '@nx/devkit';
-
+import {
+  readProjectConfiguration,
+  Tree,
+  updateProjectConfiguration,
+} from '@nx/devkit';
 import update from './add-vite-plugin';
+import { TempFs } from 'nx/src/internal-testing-utils/temp-fs';
+import { UserConfig } from 'vite';
 
-describe('add-vite-plugin migration', () => {
+describe('add-nx-cypress-plugin migration', () => {
   let tree: Tree;
+  let tempFs: TempFs;
+
+  function mockViteConfig(configPath: string, config: UserConfig) {
+    jest.mock(
+      configPath,
+      () => ({
+        default: config,
+      }),
+      {
+        virtual: true,
+      }
+    );
+  }
+
+  beforeEach(async () => {
+    tempFs = new TempFs('test');
+    tree = createTreeWithEmptyWorkspace();
+    tree.root = tempFs.tempDir;
+    await tempFs.createFiles({
+      'my-app/vite.config.ts': '',
+      'my-app/project.json': '{ "name": "my-app" }',
+    });
+    tree.write('my-app/vite.config.ts', `console.log('hi');`);
+  });
 
-  beforeEach(() => {
-    tree = createTreeWithEmptyWorkspace({ layout: 'apps-libs' });
+  afterEach(() => {
+    jest.resetModules();
+    tempFs.cleanup();
   });
 
-  it('should run successfully', async () => {
+  it('should remove the serve target', async () => {
+    mockViteConfig('vite.config.ts', {});
+    updateProjectConfiguration(tree, 'my-app', {
+      root: 'my-app',
+      targets: {
+        serve: {
+          executor: '@nx/vite:dev-server',
+          defaultConfiguration: 'development',
+          options: {
+            buildTarget: 'my-app:build',
+          },
+          configurations: {
+            development: {
+              buildTarget: 'my-app:build:development',
+              hmr: true,
+            },
+            production: {
+              buildTarget: 'my-app:build:production',
+              hmr: false,
+            },
+          },
+        },
+      },
+    });
+
     await update(tree);
-    // ... expect changes made
+
+    expect(
+      readProjectConfiguration(tree, 'my-app').targets.serve
+    ).toBeUndefined();
   });
 });

packages/vite/src/plugins/plugin.spec.ts

@@ -2,7 +2,7 @@ import { CreateNodesContext } from '@nx/devkit';
 import type { UserConfig } from 'vite';
 import { createNodes } from './plugin';
 import { TempFs } from 'nx/src/internal-testing-utils/temp-fs';
-import { join } from 'path';
+
 describe('@nx/vite/plugin', () => {
   let createNodesFunction = createNodes[1];
   let context: CreateNodesContext;