fix(web): in webpack style-loader should be used when extract-css is …

…false (#10192) * fix(web): in webpack style-loader should be used when extract-css is false * fix(web): remove unnecessary fallback true value is already being read from schema
nrwl · Jun 15, 2022 · f7a61dc · f7a61dc · vercel · Jun 15, 2022
1 parent 25b2682
commit f7a61dc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/docs/generated/packages/web.json b/docs/generated/packages/web.json
@@ -430,7 +430,7 @@
           "extractCss": {
             "type": "boolean",
             "description": "Extract CSS into a `.css` file.",
-            "default": false
+            "default": true
           },
           "es2015Polyfills": {
             "description": "Conditional polyfills loaded in browsers which do not support `ES2015`.",

diff --git a/packages/web/src/executors/webpack/schema.json b/packages/web/src/executors/webpack/schema.json
@@ -165,7 +165,7 @@
     "extractCss": {
       "type": "boolean",
       "description": "Extract CSS into a `.css` file.",
-      "default": false
+      "default": true
     },
     "es2015Polyfills": {
       "description": "Conditional polyfills loaded in browsers which do not support `ES2015`.",

diff --git a/packages/web/src/executors/webpack/webpack.impl.ts b/packages/web/src/executors/webpack/webpack.impl.ts
@@ -63,6 +63,8 @@ export interface WebWebpackExecutorOptions extends BuildBuilderOptions {
   generateIndexHtml?: boolean;
 
   postcssConfig?: string;
+
+  extractCss?: boolean;
 }
 
 async function getWebpackConfigs(

diff --git a/packages/web/src/utils/web.config.ts b/packages/web/src/utils/web.config.ts
@@ -72,7 +72,7 @@ export function getWebConfig(
       wco.root,
       wco.projectRoot,
       wco.buildOptions,
-      true,
+      options.extractCss,
       options.postcssConfig
     ),
     getCommonPartial(wco),