fix(core): scheduler should notify the life cycle about task scheduling

nrwl · Jun 16, 2022 · fadd03c · fadd03c · vercel · Jun 16, 2022
1 parent 821362f
commit fadd03c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/nx/src/tasks-runner/tasks-schedule.spec.ts b/packages/nx/src/tasks-runner/tasks-schedule.spec.ts
@@ -21,6 +21,7 @@ describe('TasksSchedule', () => {
   let app1Build: Task;
   let app2Build: Task;
   let lib1Build: Task;
+  let lifeCycle: any;
   beforeEach(() => {
     app1Build = createMockTask('app1:build');
     app2Build = createMockTask('app2:build');
@@ -88,17 +89,18 @@ describe('TasksSchedule', () => {
       hashTaskWithDepsAndContext: () => 'hash',
     } as any;
 
+    lifeCycle = {
+      startTask: jest.fn(),
+      endTask: jest.fn(),
+      scheduleTask: jest.fn(),
+    };
     taskSchedule = new TasksSchedule(
       hasher,
       projectGraph,
       taskGraph,
       workspace as Workspaces,
       {
-        lifeCycle: {
-          startTask: jest.fn(),
-          endTask: jest.fn(),
-          scheduleTask: jest.fn(),
-        },
+        lifeCycle,
       }
     );
   });
@@ -125,6 +127,11 @@ describe('TasksSchedule', () => {
       expect(taskSchedule.nextTask()).toEqual(app2Build);
     });
 
+    it('should invoke lifeCycle.scheduleTask', async () => {
+      await taskSchedule.scheduleNextTasks();
+      expect(lifeCycle.scheduleTask).toHaveBeenCalled();
+    });
+
     it('should not schedule any tasks that still have uncompleted dependencies', async () => {
       await taskSchedule.scheduleNextTasks();
       taskSchedule.nextTask();

diff --git a/packages/nx/src/tasks-runner/tasks-schedule.ts b/packages/nx/src/tasks-runner/tasks-schedule.ts
@@ -87,6 +87,7 @@ export class TasksSchedule {
       this.notScheduledTaskGraph,
       [taskId]
     );
+    this.options.lifeCycle.scheduleTask(task);
     this.scheduledTasks.push(taskId);
   }