fix(testing): update v14 migration and migrate jest.config.ts to use export default
#10035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
from
515798c
to
f74edd6
Compare
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
from
f74edd6
to
0be0d30
Compare
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
from
0be0d30
to
0c39a48
Compare
This was
linked to
issues
Apr 29, 2022
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
from
0c39a48
to
fad1c30
Compare
barbados-clemens
changed the title
jest.config.ts to use export default
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
from
864d1c6
to
009b01c
Compare
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
4 times, most recently
from
7b72219
to
41d4928
Compare
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
2 times, most recently
from
f7c243f
to
7a6e1f5
Compare
…rserOptions fixes: #9982
FrozenPandaz
approved these changes
May 11, 2022
| tree.write( | ||
| 'jest.config.js', | ||
| ` | ||
| xit('should work with async functions', async () => { |
There was a problem hiding this comment.
it was never supported when the initial file was created IIRC for whatever reason this file got mostly reformatted. this whole thing needs to be rewritten to use the AST better and prevent the usage of runInContext + relative import error that we came across with the v14 jest migration.
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
from
7a6e1f5
to
6584993
Compare
barbados-clemens
force-pushed
the
update-14-jest-migration
branch
from
6584993
to
40c1b88
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
linting errors after running jest migration
still using module.exports in a ts file
Expected Behavior
no linting errors after running migration
using export default in jest.config.ts
Related Issue(s)
Fixes #10021 #9982 #9973