-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): update v14 migration and migrate jest.config.ts
to use export default
#10035
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
515798c
to
f74edd6
Compare
f74edd6
to
0be0d30
Compare
0be0d30
to
0c39a48
Compare
0c39a48
to
fad1c30
Compare
jest.config.ts
to use export default
864d1c6
to
009b01c
Compare
7b72219
to
41d4928
Compare
f7c243f
to
7a6e1f5
Compare
…rserOptions fixes: #9982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can you rebase please?
tree.write( | ||
'jest.config.js', | ||
` | ||
xit('should work with async functions', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was never supported when the initial file was created IIRC for whatever reason this file got mostly reformatted. this whole thing needs to be rewritten to use the AST better and prevent the usage of runInContext + relative import error that we came across with the v14 jest migration.
7a6e1f5
to
6584993
Compare
6584993
to
40c1b88
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
linting errors after running jest migration
still using module.exports in a ts file
Expected Behavior
no linting errors after running migration
using export default in jest.config.ts
Related Issue(s)
Fixes #10021 #9982 #9973