Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix collecting secondary entry points for module federation builds #10129

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

Building an application with Module Federation setup can fail when a dependency contains a subfolder with a package.json but it's not really a secondary entry point (e.g. sample folders). Also, the generated configuration for shared packages might have requiredVersion: undefined when the package is not in the dependencies property of the root package.json.

Expected Behavior

Secondary entry points should be correctly identified and the shared dependencies should set the right requiredVersion whenever possible, otherwise, it should remove the shared dependency and warn about it.

Related Issue(s)

Fixes #10094

@leosvelperez leosvelperez requested a review from Coly010 May 4, 2022 12:57
@leosvelperez leosvelperez self-assigned this May 4, 2022
@vercel
Copy link

vercel bot commented May 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 4, 2022 at 1:01PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically shared package includes sample projects from npm package
2 participants