fix(angular): fix collecting secondary entry points for module federation builds #10129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Building an application with Module Federation setup can fail when a dependency contains a subfolder with a
package.json
but it's not really a secondary entry point (e.g. sample folders). Also, the generated configuration for shared packages might haverequiredVersion: undefined
when the package is not in thedependencies
property of the rootpackage.json
.Expected Behavior
Secondary entry points should be correctly identified and the shared dependencies should set the right
requiredVersion
whenever possible, otherwise, it should remove the shared dependency and warn about it.Related Issue(s)
Fixes #10094