Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add support for passing additional shared dependencies in the module federation config #10156

Merged

Conversation

leosvelperez
Copy link
Member

Adds a new optional additionalShared property to the withModuleFederation function options that allow providing additional shared dependencies.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from Coly010 May 5, 2022 10:31
@leosvelperez leosvelperez self-assigned this May 5, 2022
@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 5, 2022 at 10:34AM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Are we supporting string, tuple and object?

@leosvelperez
Copy link
Member Author

LGTM!

Are we supporting string, tuple and object?

Yeah. Can definitely remove the tuple or the object. Left both because it was simple to support and gives flexibility. The tuple is more concise while the object is better for readability.

@leosvelperez leosvelperez merged commit b8c175f into nrwl:master May 5, 2022
@leosvelperez leosvelperez deleted the angular/mf-additional-shared branch May 5, 2022 14:09
Copy link

@mrehman7095 mrehman7095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants