-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): add support for passing additional shared dependencies in the module federation config #10156
feat(angular): add support for passing additional shared dependencies in the module federation config #10156
Conversation
… in the module federation config
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Are we supporting string, tuple and object?
Yeah. Can definitely remove the tuple or the object. Left both because it was simple to support and gives flexibility. The tuple is more concise while the object is better for readability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Adds a new optional
additionalShared
property to thewithModuleFederation
function options that allow providing additional shared dependencies.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #