Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): remove collected dependency from module federation shared config when not found in package.json #10157

Merged
merged 1 commit into from May 5, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

The generated configuration for shared packages might have requiredVersion: undefined when the package is not in the dependencies property of the root package.json.

Expected Behavior

The collected shared dependencies should set the right requiredVersion whenever possible, otherwise, it should remove the shared dependency and warn about it.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this May 5, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 5, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 29d60d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 5, 2022 at 10:47AM (UTC)

@jaysoo jaysoo merged commit 67e233d into nrwl:master May 5, 2022
@jaysoo
Copy link
Member

jaysoo commented May 5, 2022

LGTM

@leosvelperez leosvelperez deleted the react/mf-deps-collection branch May 5, 2022 14:46
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants