fix(core): store relative file name in hash details #10166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
fix/implicit-deps-relative-path
branch
from
ad99040
to
abf8131
Compare
AgentEnder
force-pushed
the
fix/implicit-deps-relative-path
branch
from
abf8131
to
5692722
Compare
vsavkin
reviewed
Jun 3, 2022
vsavkin
requested changes
Jun 3, 2022
AgentEnder
force-pushed
the
fix/implicit-deps-relative-path
branch
from
5692722
to
f8bb12c
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When
NX_VERBOSE_LOGGINGis set, the logged hash details contain absolute file paths. Since the path itself is not considered currently, this doesn't cause cache misses.Expected Behavior
When
NX_VERBOSE_LOGGINGis set, the logged hash details contain relative file paths. If the path itself is considered, this doesn't cause cache misses.Related Issue(s)
Fixes #