-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): store relative file name in hash details #10166
fix(core): store relative file name in hash details #10166
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ad99040
to
abf8131
Compare
abf8131
to
5692722
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using the default hasher is a good idea. However, we should not invoke ensureinitialized
5692722
to
f8bb12c
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When
NX_VERBOSE_LOGGING
is set, the logged hash details contain absolute file paths. Since the path itself is not considered currently, this doesn't cause cache misses.Expected Behavior
When
NX_VERBOSE_LOGGING
is set, the logged hash details contain relative file paths. If the path itself is considered, this doesn't cause cache misses.Related Issue(s)
Fixes #