Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of remote module required to be remoteEntry.mjs #10206

Closed
oschlegel opened this issue May 9, 2022 · 5 comments · Fixed by #10432 or #12302
Closed

Name of remote module required to be remoteEntry.mjs #10206

oschlegel opened this issue May 9, 2022 · 5 comments · Fixed by #10432 or #12302
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: question / discussion

Comments

@oschlegel
Copy link
Contributor

Hi, i'm integrating your module federation features for a projct and found out that you required the name of remote modules for be remoteEntry.mjs here. This is a issue since i have to integrate remote modules which are named differently. Wouldn't it be a better approach to check if remoteUrl already includes the filename and only add remoteEntry.mjs as fallback?

   Node : 16.14.0
   OS   : darwin x64
   npm  : 8.3.1
   
   nx : 14.1.4
   @nrwl/angular : 14.1.4
   @nrwl/cypress : 14.1.4
   @nrwl/detox : Not Found
   @nrwl/devkit : 14.1.4
   @nrwl/eslint-plugin-nx : 14.1.4
   @nrwl/express : Not Found
   @nrwl/jest : 14.1.4
   @nrwl/js : Not Found
   @nrwl/linter : 14.1.4
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/schematics : Not Found
   @nrwl/storybook : 14.1.4
   @nrwl/web : Not Found
   @nrwl/workspace : 14.1.4
   typescript : 4.6.3
   rxjs : 7.4.0
   ---------------------------------------
   Community plugins:
         @ngneat/spectator: 10.0.0
         angular-playground: 9.0.1
         ng-mocks: 13.1.0
@Coly010
Copy link
Contributor

Coly010 commented May 10, 2022

Hey 😄

Are you also using our withModuleFederation helper to expose the remote entry? If so, it is also set to remoteEntry.mjs. Where do you have a difference?

@oschlegel
Copy link
Contributor Author

oschlegel commented May 11, 2022

Hi, i have a mixed setup. Part of my remote modules are located within my nx workspace and are using withModuleFederation, but other remote modules are maintained by other teams in other repostories which are not using nx tooling.

@ubergeoff
Copy link

ubergeoff commented Aug 24, 2022

Can we also have this fixed for the manifest files..?

i.e. using using the setRemoteDefinitions helper function...

@Kavebo
Copy link

Kavebo commented Oct 12, 2022

How did you manage to configure Nx monorepo to use module which is now build with withModuleFederation? I'm trying to do it 2 days without success. All examples are just using apps from monorepo itself or it's configured with ModuleFederationPlugin without nx tooling.

I'm always getting error like:
fn is not a function. (In 'fn(arg1, arg2)', 'fn' is undefined) while loading "./Module" from 2636

remoteEntry.js from "external" repo app is loaded but this is everything.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: question / discussion
Projects
None yet
5 participants