fix(webpack): regression from #10432 to allow // prefix

[neo]

Current Behavior

Provided ModuleFederationConfig of the following:

  remotes: [
    ['about', '//localhost:4201/'],
    ['cart', '//localhost:4202/'],
    ['shop', '//localhost:4203/'],
  ],

It ends up requesting http://localhost:4200/localhost:4201/remoteEntry.js

And I think we shouldn't use path.join because it would normalize the double slash to become single:

$ node -e "console.log(require('path').join('//localhost:4201/', 'remoteEntry.js'))"
> /localhost:4201/remoteEntry.js

Expected Behavior

It should assemble the URL correctly and request http://localhost:4201/remoteEntry.js instead.

Related Issue(s)

I believe it's a regression introduced by #10432 when trying to fix #10206.

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 754ed15. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=e2e --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=754ed15d3fdcd7a56ca7c18a8616907c9003e3ae --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
• nx affected --target=test --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=754ed15d3fdcd7a56ca7c18a8616907c9003e3ae --parallel=1
• nx affected --target=build --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=754ed15d3fdcd7a56ca7c18a8616907c9003e3ae --parallel=3
• nx-cloud record -- yarn depcheck
• nx affected --target=lint --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=754ed15d3fdcd7a56ca7c18a8616907c9003e3ae --parallel=3
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn check-lock-files
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=3c6bff2a0f76ef18ef1a88878f96d6bfe8c3b719 --head=754ed15d3fdcd7a56ca7c18a8616907c9003e3ae
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn documentation
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Sep 29, 2022 at 3:47AM (UTC)

[Coly010]

LGTM! 🎉 Thanks for the PR!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.