Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): support alternate remote entry filenames #10206 #10432

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 23, 2022

Current Behavior

We currently expect remotes to be set up using a filename with either remoteEntry.mjs or remoteEntry.js.

There are some use cases where teams will have legacy remotes outside their current Nx Monorepo that are using names that do not conform to this filename assumption.

Expected Behavior

We should allow for any filename in the remote location set up in the remotes array.

Related Issue(s)

Fixes #10206

@Coly010 Coly010 requested a review from jaysoo May 23, 2022 11:35
@Coly010 Coly010 self-assigned this May 23, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 471910e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented May 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 24, 2022 at 9:14AM (UTC)

@Coly010 Coly010 force-pushed the module-federation/support-alternate-filenames branch from 5ba58b7 to 98c14d9 Compare May 23, 2022 15:19
@Coly010 Coly010 requested a review from leosvelperez May 23, 2022 18:45
@Coly010 Coly010 force-pushed the module-federation/support-alternate-filenames branch from 98c14d9 to 471910e Compare May 24, 2022 09:13
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit a299469 into nrwl:master May 24, 2022
@Coly010 Coly010 deleted the module-federation/support-alternate-filenames branch May 24, 2022 11:16
FrozenPandaz pushed a commit that referenced this pull request Sep 29, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name of remote module required to be remoteEntry.mjs
2 participants