New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): support alternate remote entry filenames #10206 #10432
Merged
Coly010
merged 1 commit into
nrwl:master
from
Coly010:module-federation/support-alternate-filenames
May 24, 2022
Merged
feat(angular): support alternate remote entry filenames #10206 #10432
Coly010
merged 1 commit into
nrwl:master
from
Coly010:module-federation/support-alternate-filenames
May 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
force-pushed
the
module-federation/support-alternate-filenames
branch
from
May 23, 2022 15:19
5ba58b7
to
98c14d9
Compare
Coly010
force-pushed
the
module-federation/support-alternate-filenames
branch
from
May 24, 2022 09:13
98c14d9
to
471910e
Compare
leosvelperez
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Coly010
pushed a commit
that referenced
this pull request
Sep 29, 2022
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently expect remotes to be set up using a filename with either
remoteEntry.mjs
orremoteEntry.js
.There are some use cases where teams will have legacy remotes outside their current Nx Monorepo that are using names that do not conform to this filename assumption.
Expected Behavior
We should allow for any filename in the remote location set up in the remotes array.
Related Issue(s)
Fixes #10206