Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating leads to wrong @storybook/addon-notes version #10484

Closed
timtos opened this issue May 26, 2022 · 4 comments · Fixed by #10568
Closed

Migrating leads to wrong @storybook/addon-notes version #10484

timtos opened this issue May 26, 2022 · 4 comments · Fixed by #10568
Assignees
@mandarini
Labels
outdated scope: storybook Issues related to Storybook support in Nx type: bug

Comments

@timtos
Copy link

timtos commented May 26, 2022

Current Behavior

Migrating to nx version 14.1.9 bumps @storybook/addon-notes version to 6.4.12 which does not exist. The latest package version available is still 5.3.21.

Expected Behavior

The migration process should stick to version 5.3.21.

Steps to Reproduce

Migrate to the latest version and check the package.json.
Running yarn will let you choose a version as the "migrated version" does not exist.

Environment

Node : 16.13.2
OS : win32 x64
yarn : 1.22.5
@timtos timtos mentioned this issue May 26, 2022
Closed
@AgentEnder AgentEnder added the scope: storybook Issues related to Storybook support in Nx label May 26, 2022
@mandarini mandarini self-assigned this May 31, 2022
@mandarini
Copy link
Member

Ooops!!! Fix on it's way!! Thanks for reporting @timtos !

@mandarini
Copy link
Member

Quick question. Which version did you migrate FROM? @timtos

mandarini added a commit to mandarini/nx that referenced this issue Jun 3, 2022
@mandarini
fix(storybook): ignore addon-notes from version update
1b70319 
ISSUES CLOSED:  nrwl#10484
@mandarini mandarini mentioned this issue Jun 3, 2022
Merged
mandarini added a commit that referenced this issue Jun 3, 2022
@mandarini
fix(storybook): ignore addon-notes from version update (#10568)
189c036 
ISSUES CLOSED:  #10484
@timtos
Copy link
Author

timtos commented Jun 3, 2022

@mandarini Probably too late, but I still want to answer: The version was 13.8.8. Thank you for the fix! 👍

@mandarini mandarini mentioned this issue Aug 30, 2022
Closed
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mandarini mandarini

Labels
outdated scope: storybook Issues related to Storybook support in Nx type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storybook): ignore addon-notes from version update mandarini/nx
3 participants
@timtos @mandarini @AgentEnder