Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): ignore addon-notes from version update #10568

Merged
merged 1 commit into from Jun 3, 2022

Conversation

mandarini
Copy link
Member

ISSUES CLOSED: #10484

Current Behavior

Storybook migration tries to update a deprecated, unmaintained package.

Expected Behavior

Storybook migration should ignore that package and not try to update it

Related Issue(s)

#10484

Fixes #10484

@nx-cloud
Copy link

nx-cloud bot commented Jun 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1b70319. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@mandarini mandarini self-assigned this Jun 3, 2022
@vercel
Copy link

vercel bot commented Jun 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 3, 2022 at 10:03AM (UTC)

@mandarini mandarini enabled auto-merge (squash) June 3, 2022 10:02
@mandarini mandarini added the scope: storybook Issues related to Storybook support in Nx label Jun 3, 2022
@mandarini mandarini merged commit 189c036 into nrwl:master Jun 3, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: storybook Issues related to Storybook support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating leads to wrong @storybook/addon-notes version
1 participant