Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): return empty array if no helper dependencies found #10582

Merged
merged 2 commits into from Jun 4, 2022

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Jun 4, 2022

Current Behavior

one code path returns undefined instead of []. This results in failing build if a Node application does not have depend on any helper dependency (eg: tslib)

Expected Behavior

build should pass regardless of the app requiring helper dependency or not

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Jun 4, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c0aff7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Jun 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jun 4, 2022 at 3:32AM (UTC)

@nartc nartc marked this pull request as ready for review June 4, 2022 03:32
@nartc nartc merged commit 5daeaf8 into master Jun 4, 2022
@FrozenPandaz FrozenPandaz deleted the helper-dependencies-return-default branch June 7, 2022 23:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant