Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): remove projectBuildConfig from everywhere #10664

Merged

Conversation

mandarini
Copy link
Member

Current Behavior

The projectBuildConfig flag, meant for Nx versions <14.1.8, is no longer used anywhere. It still exists, however, in the executor/generator schemas. It is safe to remove it.

Expected Behavior

The unused projectBuildConfig flag is now removed from the schemas

@nx-cloud
Copy link

nx-cloud bot commented Jun 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 85c2722. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@mandarini mandarini self-assigned this Jun 9, 2022
@vercel
Copy link

vercel bot commented Jun 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jun 9, 2022 at 2:51PM (UTC)

@mandarini mandarini force-pushed the fix/remove-project-build-config-flag branch from bb525ee to 85c2722 Compare June 9, 2022 14:49
@mandarini mandarini enabled auto-merge (squash) June 9, 2022 14:49
@mandarini mandarini merged commit 1fe3ba6 into nrwl:master Jun 9, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants