Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): remove projectBuildConfig from everywhere #10664

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/generated/packages/react.json
Original file line number Diff line number Diff line change
Expand Up @@ -639,10 +639,6 @@
"enum": ["eslint", "tslint"],
"default": "eslint"
},
"projectBuildConfig": {
"description": "Provide a custom projectBuildConfig for the Angular executor. If left blank, Nx will use the default.",
"type": "string"
},
"standaloneConfig": {
"description": "Split the project configuration into `<projectRoot>/project.json` rather than including it inside `workspace.json`.",
"type": "boolean"
Expand Down
8 changes: 0 additions & 8 deletions docs/generated/packages/storybook.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@
"enum": ["eslint", "tslint", "none"],
"default": "eslint"
},
"projectBuildConfig": {
"description": "Provide a custom projectBuildConfig for the Angular executor. If left blank, Nx will use the default.",
"type": "string"
},
"js": {
"type": "boolean",
"description": "Generate JavaScript story files rather than TypeScript story files.",
Expand Down Expand Up @@ -369,10 +365,6 @@
"type": "string",
"description": "The output path of the generated files."
},
"projectBuildConfig": {
"type": "string",
"description": "Workspace project where Storybook reads the Webpack config from."
},
"styles": {
"type": "array",
"description": "Global styles to be included in the build.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ export interface StorybookConfigureSchema {
linter?: Linter;
cypressDirectory?: string;
standaloneConfig?: boolean;
projectBuildConfig?: string;
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@
"enum": ["eslint", "tslint"],
"default": "eslint"
},
"projectBuildConfig": {
"description": "Provide a custom projectBuildConfig for the Angular executor. If left blank, Nx will use the default.",
"type": "string"
},
"standaloneConfig": {
"description": "Split the project configuration into `<projectRoot>/project.json` rather than including it inside `workspace.json`.",
"type": "boolean"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
"type": "string",
"description": "The output path of the generated files."
},
"projectBuildConfig": {
"type": "string",
"description": "Workspace project where Storybook reads the Webpack config from."
},
"styles": {
"type": "array",
"description": "Global styles to be included in the build.",
Expand Down
1 change: 0 additions & 1 deletion packages/storybook/src/executors/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ export interface CommonNxStorybookConfig {
| '@storybook/vue3'
| '@storybook/svelte'
| '@storybook/react-native';
projectBuildConfig?: string;
config: StorybookConfig;
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ export interface StorybookConfigureSchema {
tsConfiguration?: boolean;
cypressDirectory?: string;
standaloneConfig?: boolean;
projectBuildConfig?: string;
}
4 changes: 0 additions & 4 deletions packages/storybook/src/generators/configuration/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
"enum": ["eslint", "tslint", "none"],
"default": "eslint"
},
"projectBuildConfig": {
"description": "Provide a custom projectBuildConfig for the Angular executor. If left blank, Nx will use the default.",
"type": "string"
},
"js": {
"type": "boolean",
"description": "Generate JavaScript story files rather than TypeScript story files.",
Expand Down