fix(core): fix print-affected not filtering on target #12355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jefflage
added a commit
to jefflage/nx
that referenced
this pull request
Sep 30, 2022
jefflage
added a commit
to jefflage/nx
that referenced
this pull request
Sep 30, 2022
|
Some e2e tests are failing, can you take a look please? |
I've tried several times. They don't run green for me from master without my changes. No matter where I drop in logging, I can't seem to get any information as to why they fail with my changes either. Unless you think differently, I plan to just close the PR. |
When invoked with a --target=x argument, print-affected was not filtering the results shown to only projects with that target ISSUES CLOSED: nrwl#11645
AgentEnder
force-pushed
the
print-affect-with-target
branch
from
49a9aa4
to
c5c6355
Compare
FrozenPandaz
force-pushed
the
print-affect-with-target
branch
from
c80d81a
to
8b6ece7
Compare
FrozenPandaz
approved these changes
Oct 27, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoked with a --target=x argument, print-affected was not filtering the results shown to only
projects with that target
ISSUES CLOSED: #11645
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #