Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add skipPackageJson flag #12919

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 1, 2022

Current Behavior

Adding a new library may always update package.json when it is unnecessary or when it is unwanted behaviour (if the developer has specific versions of packages for a reason).

Expected Behavior

Add the skipPackageJson flag that to the library generator (and subsequent generators that require it) to allow the developer to specifically state if they want the dependencies modified.
This follows the pattern seen in other @nrwl/* packages.

@Coly010 Coly010 requested a review from jaysoo November 1, 2022 14:19
@Coly010 Coly010 self-assigned this Nov 1, 2022
@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 2:21PM (UTC)

@jaysoo jaysoo merged commit 4a4a149 into nrwl:master Nov 2, 2022
@Coly010 Coly010 deleted the react/add-skip-package-json branch November 2, 2022 18:21
@Coly010 Coly010 restored the react/add-skip-package-json branch November 9, 2022 18:39
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants