Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): convert to monorepo generator should respect nested libs #18795

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

Currently when we run nx g @nx/workspace:convert-to-monorepo while having a nested lib

apis/login/src/login.ts

it would generate

libs/apis-login/

Expected Behavior

Expected it to generate

libs/apis/login/

Related Issue(s)

Fixes #

@ndcunningham ndcunningham added the scope: core core nx functionality label Aug 23, 2023
@ndcunningham ndcunningham self-assigned this Aug 23, 2023
@ndcunningham ndcunningham requested a review from a team as a code owner August 23, 2023 18:08
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 2:17pm

@ndcunningham ndcunningham force-pushed the fix/convert-to-monorepo-respect-nested-lib branch from a3d4a46 to 017456d Compare August 25, 2023 14:17
@ndcunningham ndcunningham merged commit 413e57f into nrwl:master Aug 25, 2023
15 checks passed
@ndcunningham ndcunningham deleted the fix/convert-to-monorepo-respect-nested-lib branch August 25, 2023 20:15
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants