-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): convert to monorepo generator should respect nested libs #18795
Merged
ndcunningham
merged 1 commit into
nrwl:master
from
ndcunningham:fix/convert-to-monorepo-respect-nested-lib
Aug 25, 2023
Merged
fix(core): convert to monorepo generator should respect nested libs #18795
ndcunningham
merged 1 commit into
nrwl:master
from
ndcunningham:fix/convert-to-monorepo-respect-nested-lib
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
approved these changes
Aug 23, 2023
ndcunningham
force-pushed
the
fix/convert-to-monorepo-respect-nested-lib
branch
from
August 24, 2023 15:20
52e9813
to
3b1cf2e
Compare
ndcunningham
force-pushed
the
fix/convert-to-monorepo-respect-nested-lib
branch
from
August 25, 2023 00:24
3b1cf2e
to
a3d4a46
Compare
ndcunningham
force-pushed
the
fix/convert-to-monorepo-respect-nested-lib
branch
from
August 25, 2023 14:17
a3d4a46
to
017456d
Compare
AgentEnder
approved these changes
Aug 25, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently when we run
nx g @nx/workspace:convert-to-monorepo
while having a nested libit would generate
Expected Behavior
Expected it to generate
Related Issue(s)
Fixes #