fix(core): prettier 3 shouldn't cause errors due to esm + compile cache

[AgentEnder]

Current Behavior

Folks receive a weird invalid host options received error when trying to run prettier v3 or other ESM packages during generators or format

Expected Behavior

These errors don't happen.

Related Issue(s)

Fixes #18974
Fixes #18721

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview		Sep 6, 2023 9:37pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2786a8f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected --target=e2e --base=2bc70310170c59b039c3b506189e17f1a9a6ce0c --head=2786a8ff993ae23b1ffac827ea906935623f4954 --parallel=1
• nx affected --target=test --base=2bc70310170c59b039c3b506189e17f1a9a6ce0c --head=2786a8ff993ae23b1ffac827ea906935623f4954 --parallel=1
• nx affected --target=build --base=2bc70310170c59b039c3b506189e17f1a9a6ce0c --head=2786a8ff993ae23b1ffac827ea906935623f4954 --parallel=3
• nx affected --target=lint --base=2bc70310170c59b039c3b506189e17f1a9a6ce0c --head=2786a8ff993ae23b1ffac827ea906935623f4954 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=2bc70310170c59b039c3b506189e17f1a9a6ce0c --head=2786a8ff993ae23b1ffac827ea906935623f4954
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=2bc70310170c59b039c3b506189e17f1a9a6ce0c --head=2786a8ff993ae23b1ffac827ea906935623f4954

---

Sent with 💌 from NxCloud.

[pongells]

I am on 16.8.1 using Yarn2 with PNP, fix does not seem to work, I still have to add DISABLE_V8_COMPILE_CACHE=1

[AgentEnder]

Yeah, there was a follow up PR that tidies up a bit of this thats not been released just yet.

[sauldeleon]

Can confirm that applying this fix solves the issue for me. Thanks!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.