Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prettier 3 shouldn't cause errors due to v8 compile cache #19075

Merged
merged 1 commit into from Sep 8, 2023

Conversation

guysenpai
Copy link
Contributor

Current Behavior

After fix #19042 the errors remain

Expected Behavior

Theses errors should no longer appear

Related Issue(s)

Fixes #18721

@guysenpai guysenpai requested a review from a team as a code owner September 8, 2023 11:59
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2023 11:59am

@AgentEnder AgentEnder merged commit e507ff0 into nrwl:master Sep 8, 2023
14 checks passed
@d0whc3r
Copy link

d0whc3r commented Sep 14, 2023

This will fail when using nx format:write command in lint-staged, because now in https://github.com/nrwl/nx/blob/master/packages/nx/src/command-line/format/format.ts#L85 it is a "Promise"

https://github.com/nrwl/nx/blob/master/packages/nx/src/command-line/format/format.ts#L84

const supportedExtensions = (await prettier
      .getSupportInfo())
      .languages.flatMap((language) => language.extensions)
      .filter((extension) => !!extension)
      // Prettier supports ".swcrc" as a file instead of an extension
      // So we add ".swcrc" as a supported extension manually
      // which allows it to be considered for calculating "patterns"
      .concat('.swcrc');

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 bug: prettier 3 error Invalid host defined options
3 participants